[Driver][NFC] Fix build warning with size comparison #15860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hchilama
approved these changes
Oct 24, 2024
Contributor
|
The PR title mentions that this fixes a build warning. |
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
This can be captured if we do something like build the compiler with -Werror or just manually examining the output from the build to see if any warnings are emitted. This was actually caught with our xmain builds which do use |
srividya-sundaram
approved these changes
Oct 24, 2024
Contributor
Author
|
@intel/llvm-gatekeepers, this looks ready to be merged, please take a look - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.